mickelus / tetra

🔶- Source and issue tracker for tetra
https://minecraft.curseforge.com/projects/tetra
MIT License
174 stars 79 forks source link

[Bug] Some vanilla enchants can't be applied when Ensorcellation is installed. #645

Open SuperStormer opened 2 years ago

SuperStormer commented 2 years ago

Observed behaviour

Some enchanted books aren't accepted when you attempt to enchant a tool with the Tetra workbench when Ensorcellation is installed.

I only tested Fire Aspect, Looting, Knockback on swords, though there may be other enchants that also don't work.

However, Sharpness, Bane of Arthropods and Unbreaking do work on the same sword. All 6 of these enchantments are accepted when Ensorcellation (and CoFH Core) is disabled. Disabling the corresponding config option (eg. Overrides.Looting) in ensorcellation-server.toml has no effect.

Expected behaviour

Fire Aspect, Looting and Knockback are accepted when you try to enchant a sword in the workbench.

Steps to reproduce

  1. Place sword in Tetra workbench
  2. Select blade -> enchant
  3. Place Fire Aspect, Looting or Knockback in book slot
  4. Attempt to click "Craft" Button
  5. Observe that a popup appears that says "The provided material cannot be used for this schematic", and the sword remains unenchanted.

Crashlog

No response

Tetra version

4.9.3

mutil/mGui version

4.5.0

Forge version

1.18.2 - 40.1.68

Other mods

CoFH Core v1.6.4.21 Ensorcellation v1.6.1.8

SuperStormer commented 2 years ago

I'm also going to cross-post this issue to the CoFH discord in case its an issue on their end.

Hekera commented 2 years ago

Ensorc overrides some sword enchants (fire aspect, knockback, and looting) to have a different, more inclusive enchantment category, and it seems like Tetra does exact matching on categories. The easiest solution would probably be to add the affected enchantments to the additions tags.

zinerith commented 4 months ago

Just wanting to note that this bug still exists in the current release of 1.20.1

If this is in fact what is occurring, any mod that does any tweak to a vanilla enchant would render it unusable by Tetra. It's just most obvious with Encorcellation since it's the most popular additional enchantments mod in this version.