mickelus / tetra

🔶- Source and issue tracker for tetra
https://minecraft.curseforge.com/projects/tetra
MIT License
174 stars 79 forks source link

[Bug] Reaching damage is double it's tooltip value #822

Closed SomeFellaUnknown closed 2 months ago

SomeFellaUnknown commented 3 months ago

Observed behaviour

the Reaching property seems to be adding (aproximately) double the percentage multiplier listed in the tooltip for reaching, for instance if the reaching property tooltip claims that the property is going to add a +33% bonus to the damage, the damage is actiually being multiplied by +66%.

See tables / examples below:

(in all of these examples we have an entity with 0 armor and 300 health with an block position of (18.5, -58.5, 14.5) we teleport to a certain location, hit the entity and extract it's health after being hitl)

image

image

image

target lost 14.39444 health when 3 blocks away, as well as 17.16705 damage when we were 6 blocks away. Our expected damage is 12.2 and 13.6 respectively

image

image

image

target took 11.61417 damage when 3 blocks away and 12.82245 damage when 4 blocks away compared to the expected 9.31 and 9.94 damage respectively

image

image

image

target took 16.59167 damage when 3 blocks away and 20.75055 damage when 6 blocks away compared to the expected 13.3 and 15.4 damage respectively

Expected behaviour

for the tooltip to accurately describe the damage bonus of the Reaching property for the listed distances

Steps to reproduce

  1. get an NoAI entity at a known set of coordinates and known maximum health
  2. get an item with the Reaching property, note the damage percentages in the tooltip
  3. use commands to teleport yourself so that you are exactly a distance away from the target based on the distances mentioned in the tooltip for reaching (3 and the weapon's maximum reach)
  4. attack the entity in question
  5. gain the entity's current health using /data get or similar commands
  6. compare to expected damage
  7. heal target and repeat

Crashlog

No response

Tetra version

6.3.0

mutil/mGui version

6.1.1

Forge version

1.20.1 - 47.2.0

Other mods

none, i have a specific instance for testing just Tetra alone with only it's required dependencies

mickelus commented 2 months ago

Fixed in 6.4.0, thanks for the detailed issue!