Feature Request: check_files perf-config size UNIT should be reflected in status output when used in syntax

[box293]

0.4.3.131

It would be good if a UNIT was specified somewhere, it would be used in the status output.

Here's one example:

Command:
check_nrpe -H win2008r2-01 -c check_files -a file="c:\\Program Files\\NSClient++\\nsclient.log" "critical=size>100k" "perf-config=size(unit:M)" "detail-syntax=${status}%(filename) = %(size)"

Output:
CRITICAL: 0/1 files (nsclient.log = 377476)|'nsclient.log size'=0.35998M;0;0.09765

So I would prefer

CRITICAL: 0/1 files (nsclient.log = 377476)

To display as

CRITICAL: 0/1 files (nsclient.log = 0.35998M)

Here's another:

Command:
check_nrpe -H E4300 -c check_files -a path='C:\\No Backup' pattern=*.* 'filter=size gt 500M' 'critical=count>0' 'top-syntax={${count} Files Found} ${list}' 'detail-syntax=%(file): %(size)'

Output:
{8 Files Found} en_windows_7_professional_with_sp1_x64_dvd_u_676939.iso: 3320903680, VTS_01_1.VOB: 1073641472, VTS_01_2.VOB: 1073672192, VTS_01_3.VOB: 1073680384, VTS_01_4.VOB: 1073731584, VTS_01_5.VOB: 1073539072, VTS_01_6.VOB: 911251456, vMA-5.5.0.1-1663088.zip: 559425648|'count'=8;0;0

So I would prefer

en_windows_7_professional_with_sp1_x64_dvd_u_676939.iso: 3320903680

To display as

en_windows_7_professional_with_sp1_x64_dvd_u_676939.iso: 3167.06M

Because I did specify a UNIT in the filter

Or at least display what UNIT is being reported:

en_windows_7_professional_with_sp1_x64_dvd_u_676939.iso: 3320903680B

[mickem]

sounds reasonable, I will consider it for 0.4.4

[itsul]

Hi,

would be great to have this feature in one of the upcoming updates.

Or maybe it is already in?