NSClient++ returns wrong Windows version in Windows Server 2019

stephanhendl commented 4 years ago

Issue and Steps to Reproduce

We check via Icinga2 and nscp-plugin the OS version in Windows Server 2019. The result is either "Windows Server 2016 (10.0.17763)" or "Windows Server 2016 Technical Preview (10.0.17763)"

Service definition section in Icinga2:

/ OS Version / apply Service "Windows Version" { check_command = "nscp-local-os-version" command_endpoint = host.vars.clientendpoint //no nscp*_showall assign where host.vars.client_endpoint && host.vars.os == "Windows" }


### Expected Behavior

Windows Server 2019 (10.0.17763)

### Actual Behavior

"Windows Server 2016 (10.0.17763)" or "Windows Server 2016 Technical Preview (10.0.17763)".

### Details

* NSClient++ version: 0.5.2039
* Icinga2-2.11.2
* OS and Version: Windows Server 2019
* Checking from: Icinga2
* Checking with: Icinga2, check_nscp

### Additional Details

NSClient++ log:

2019-11-19 07:39:31: error:c:\source\master\modules\WEBServer\WEBServer.cpp:745: Certificate not found: C:\Program Files\NSClient++/security/certificate.pem (generating a default certificate)

stephanhendl commented 4 years ago

Please take into account: https://github.com/Icinga/icinga2/pull/774

stephanhendl commented 4 years ago

Sorry, wrong button.

mintsoft commented 4 years ago

@mickem this is confirmed under 0.5.2.41 as well, on a Server 2019 system (i.e. 1809) I get

check_os_version
L        cli OK: OK: Windows Server 2016 (10.0.17763)
L        cli  Performance data: 'version'=100;50;50

mickem commented 4 years ago

Will look into it...

kutschr commented 4 years ago

I have the same mistake. When will it be fixed?

trgrassijr55 commented 4 years ago

Great to hear I thought I was the only one having this. I just installed 5.2.41 on my 2019 Server and it reports as a 2016 Server. I was Nsclient 4.4.23 and it was reporting as a 2012 server just a little behind

Hope it is a simple fix

I will we know when this gets fixed ?

I looked thought the changes on many of the nsclient versions and did not see any mention of OS version issue being resolved.

Any notification would be helpful.

Thank you

Tom

trgrassijr55 commented 4 years ago

Will look into it...

Mickem

Any update on this?

trgrassijr55 commented 4 years ago

I just installed 5.3.4 on a Windows 2019 Server and same results still reporting as a Windows 2016 Server

Still looking for this update

trgrassijr55 commented 4 years ago

Is this site still in USE? I have not seen a response on here for several Months.

The last update was back in 2018 almost 2 years ago.

Any update versions of nsclient on the horizon?

Thank you,

Tom

trgrassijr55 commented 4 years ago

Guys, I wrote a PowerShell script to check the OS Level of my computers. I changed my check in the config to use the PowerShell script.

If anyone would like a copy let me know.

Thank you

Tom

xldcx commented 2 years ago

Any updates? As of december 2021, this still is the case for Windows 2019 - it shows up as Windows 2016. This is using NSClient++ version 0.5.2.35 - which is the latest version according to its homepage.

proebstle commented 1 year ago

Same problem with Windows Server 2022.... Windows Server 2016 (10.0.20348) = Windows Server 2022 Windows Server 2016 (10.0.17763) = Windows Server 2019

proebstle commented 1 year ago

Same problem with Windows Server 2022.... Windows Server 2016 (10.0.20348) = Windows Server 2022 Windows Server 2016 (10.0.17763) = Windows Server 2019

mickem / nscp

NSClient++ returns wrong Windows version in Windows Server 2019 #663

Issue and Steps to Reproduce