search

mickey / videojs-ga

Google Analytics plugin for video.js
MIT License
138 stars 109 forks source link

#FIX percent play for display on google analytics #17

Closed Iragne closed 11 months ago

Iragne commented 9 years ago

Hello,

Feel free to talk about it

FIX percent play for display on google analytics

ADD post function for set GA additional dimension

FIX percent play after seek in the video

mickey commented 9 years ago

Thanks a lot for your contribution @Iragne, I added a few comments.

Iragne commented 9 years ago

Hello sorry i was busy I answer to your comments

Iragne commented 9 years ago

Hello will you merge it ?

Iragne commented 8 years ago

??

kjanoudi commented 8 years ago

I find the changes made by Iragne to be useful. The current setup of percentsPlayed sends the same event every {interval} seconds (10 by default). It also includes the value of the percent played. As a result, when you're done watching a video, the data in GA shows:

percent-played: 10 events, total value: 10+20+30+40...+90+100 = 550...which is obviously incorrect.

I like Iragne's solution of string based solutions, so i will be trying to merge it into my fork with the use case.

Just thought i would add my 2 cents

Iragne commented 8 years ago

@mickey Do you like this PR ? Dose it make sense how can we follow up ?