mickeynp / combobulate

Structured Editing and Navigation in Emacs with Tree-Sitter
GNU General Public License v3.0
945 stars 54 forks source link

In TSX, attribute envelop should not enter quotes #31

Closed davazp closed 1 year ago

davazp commented 1 year ago

In TSX, when entering an attribute, "" are entered automatically:

<Component prop_|_

Pressing = will produce

<Component prop="_|_"

However, in many cases the prop values will be expressions like <Component prop={...} so it would be better to do that.

This can be disabled with combobulate-js-ts-enable-attribute-envelopes but I think it should be default to nil for TSX.

mickeynp commented 1 year ago

Thanks for the report. Can you try master?

davazp commented 1 year ago

This is still an issue. I can still disable it with the mentioned variable, but if I don't set it, it still tries to add quotes by default.

mickeynp commented 1 year ago

Oh, I misunderstood what you meant. If you try master now you can set combobulate-js-ts-attribute-envelope-default to nil to disable it.