search

mickeynp / discover.el

Discover more of emacs with context menus!
http://www.masteringemacs.org/article/discoverel-discover-emacs-context-menus
GNU General Public License v3.0
176 stars 16 forks source link

It will disable `C-x r **` #14

Open c02y opened 9 years ago

c02y commented 9 years ago

A lot of commands bound to C-x r like rectangle and bookmark and register, if I use discover, all of them will not work.

BTW, guide-key is great.

yveszoundi commented 9 years ago

+1

I believe that many users don't expect those keybindings to just vanish out of the blue. The worst thing is that the first time it happens, you have no idea about what could be wrong.

Also see this related reddit question.

This issue is also kind of a duplicate of issue #7 .

mickeynp commented 9 years ago

The problem is discover.el is a curated list of keys. I need to re-use the guide keys implementation so it'll discover uncategorized keys and add them also. But patches welcome :)

PhilHudson commented 9 years ago

+1, took too much valuable time to track down the culprit and uninstall it. As Yves said, making most of the keymap vanish silently is poor. Pity, it looked great at first. Will keep watching for updates.

mickeynp commented 9 years ago

Yes it's a common problem. I'm half tempted to rewrite discover.el on top of guidekey. Thanks for the update, Phil.

tarsius commented 9 years ago

I would suggest using @abo-abo's hydra instead.

mickeynp commented 9 years ago

Yes! That's another good choice.