search

mickeypearce / vscode-oracle-format

PL/SQL formatter (using SQLcl)
https://marketplace.visualstudio.com/items?itemName=mp.vscode-oracle-format
11 stars 4 forks source link

Escape " in paths on non-Win platforms #10

Closed mickeypearce closed 5 years ago

mickeypearce commented 5 years ago

@rafael-trevisan , I cannot push to your fork so this is a continutation of #9 .

I did a replace of " with escaped " as you suggested for non-Win platform. I will be delighted if you could test. :)

mickeypearce commented 5 years ago

If it works you can update your original PR with this change, because I am not sure if It will count you as a contributor If I merge this PR. 😨

rafael-trevisan commented 5 years ago

I am still figuring it out how to get this change as a "local extension" so I can actually test it.

It's okay if you change the code directly if you prefer to. I'll read how to install the extension locally here anyway ;)

On Tue, Mar 5, 2019 at 11:02 AM mickeypearce notifications@github.com wrote:

If it works you can update your original PR with this change, because I am not sure if It will count you as a contributor If I merge this PR. 😨

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mickeypearce/vscode-oracle-format/pull/10#issuecomment-469815937, or mute the thread https://github.com/notifications/unsubscribe-auth/AQe14gGujcghLChcsZ6IPBBpXFrch55lks5vTr9KgaJpZM4bfPtL .

mickeypearce commented 5 years ago

Usually you run npm install from your local repo directory and then launch (press F5) extension in debug mode.

mickeypearce commented 5 years ago

Solved in #11.