search

mickeypearce / vscode-oracle-format

PL/SQL formatter (using SQLcl)
https://marketplace.visualstudio.com/items?itemName=mp.vscode-oracle-format
11 stars 4 forks source link

Fix issue with quotes #11

Closed rafael-trevisan closed 5 years ago

rafael-trevisan commented 5 years ago

Closes https://github.com/mickeypearce/vscode-oracle-format/issues/5 Tested on MacOS with standard rules and custom style.xml rule file

rafael-trevisan commented 5 years ago

Hey @mickeypearce, I got the .vsix here and the proposed change works very well on MacOS. I've tested with the standard rules and a custom style.xml as well.

In the end, wasn't necessary to normalize any path. By debugging the code I could see where was missing the quotes 😉

Congrats on the very nice and useful extension and keep the good work 👍🏻

Let me know when you publish the version with the infamous quote and I'll update here.

Cheers, Rafael Trevisan

mickeypearce commented 5 years ago

Sorry I am a bit confused. For working on Mac we must include changes from #10 and #11, is that correct? I can upload a vsix if you can test.

rafael-trevisan commented 5 years ago

Nope, only the last change. Sorry if it got confused. The only change needed is this:

const cmd = "${sqlPath}" /nolog @"${formatScript}";

On Mar 5, 2019, at 11:39 PM, mickeypearce notifications@github.com wrote:

Sorry I am a bit confused. For working on Mac we must include changes from #10 and #11, is that correct? I can upload a vsix if you can test.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

mickeypearce commented 5 years ago

No problem and thanks! I will test on Win and If it works I will merge and release in a few days.

rafael-trevisan commented 5 years ago

👍🏻

On Mar 6, 2019, at 10:17 AM, mickeypearce notifications@github.com wrote:

No problem and thanks! I will test on Win and If it works I will merge and release in a few days.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

rafael-trevisan commented 5 years ago

Hi @mickeypearce, just wondering if you could test on Windows :)

mickeypearce commented 5 years ago

@rafael-trevisan , it works. thanks!

rafael-trevisan commented 5 years ago

Great! It works beautifully :)

On Fri, Mar 8, 2019 at 12:33 AM mickeypearce notifications@github.com wrote:

Merged #11 https://github.com/mickeypearce/vscode-oracle-format/pull/11 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mickeypearce/vscode-oracle-format/pull/11#event-2189484085, or mute the thread https://github.com/notifications/unsubscribe-auth/AQe14it2tZPv8NDmwUaiFWhFh5LBC4I1ks5vUiBVgaJpZM4bgJ5X .