search

mickeypearce / vscode-oracle-format

PL/SQL formatter (using SQLcl)
https://marketplace.visualstudio.com/items?itemName=mp.vscode-oracle-format
11 stars 4 forks source link

Dealing with promisify object output #15

Closed bamontelucas closed 5 years ago

bamontelucas commented 5 years ago

Hi! As suggested here I am sending a PR correcting input.search is not a function error.

I am unsure on how to test an in-dev extension, so let me know if there are any errors. (npm run test executed successfully)

mickeypearce commented 5 years ago

Thanks @bamontelucas. 👍

As there are no automatic tests included with extension yet, the only way to test is to run development extension with F5 from vscode. That should run npm run compile and execute an extension host where you can test manually.

bamontelucas commented 5 years ago

@mickeypearce Thanks for the instructions!

Worked just fine! Before: image

After: image

Output: image

mickeypearce commented 5 years ago

Thanks again, I will release asap.

I am not sure why it doesn't show your name in project contributors graph though. Maybe it has something to do with your email in commits.... hopefully is not a big deal.