search

mickeypearce / vscode-oracle-format

PL/SQL formatter (using SQLcl)
https://marketplace.visualstudio.com/items?itemName=mp.vscode-oracle-format
11 stars 4 forks source link

Format On Save doesn't appear to work #8

Closed zhudock closed 5 years ago

zhudock commented 5 years ago

I do see the command execute, the active editor script is copied to a temp file, that temp file gets formatted, but the contents never get put back in the editor.

I'm using the latest VSCode and latest version of this extension on Windows 10 Pro.

mickeypearce commented 5 years ago

Hey @zhudock , have you tried increasing default timeout: "editor.formatOnSaveTimeout": 10000 as formatting takes quite some time for larger files.

zhudock commented 5 years ago

it seems 10000 isn't sufficient. bumped it up to 15000 and things seem OK. Sorry for the false positive.

mickeypearce commented 5 years ago

I updated the readme to make it more clear.