search

mickhansen / dataloader-sequelize

Batching and simplification of Sequelize with facebook/dataloader
MIT License
284 stars 58 forks source link

Added support for sequelize v6 #103

Closed alirizwan closed 4 years ago

alirizwan commented 4 years ago

Fixes #102

alirizwan commented 4 years ago

@mickhansen Can you please help me with the test cases?

mickhansen commented 4 years ago

@alirizwan I would suggest focusing on the findByPk tests first, getting them to pass. I'll get some github actions setup to easily test each version.

alirizwan commented 4 years ago

@mickhansen there are 4 belongsToMany test cases which were failing already due to TypeError: Cannot read property 'field' of undefined in v5, maybe you can help me with those. Everything else is resolved.

mickhansen commented 4 years ago

@alirizwan I believe those failures have been there for a while, we can probably move ahead without getting them fixed.

mickhansen commented 4 years ago

Please also update https://github.com/mickhansen/dataloader-sequelize/blob/master/.github/workflows/main.yml to test v6 (add v5 line i guess)

alirizwan commented 4 years ago

@mickhansen ready to merge and publish.

mickhansen commented 4 years ago

Ah hmm test:latest doesnt run because v5 fails.

alirizwan commented 4 years ago

Ah hmm test:latest doesnt run because v5 fails.

Cam we publish this now :) I kinda am waiting on this change to publish my own package.

mickhansen commented 4 years ago

yarn run test:latest is failing locally for me, is it passing for you @alirizwan?

alirizwan commented 4 years ago

yarn run test:latest is failing locally for me, is it passing for you @alirizwan?

All test cases pass except those 4 which also fails for v5.

alirizwan commented 4 years ago

@mickhansen please see if we can merge and release.