Fix retrieving soft-deleted classes using paranoid false

mickhansen / dataloader-sequelize

Batching and simplification of Sequelize with facebook/dataloader

MIT License

284 stars 58 forks source link

Fix retrieving soft-deleted classes using paranoid false #117

Closed carelulu-igor closed 4 years ago

carelulu-igor commented 4 years ago

Hey @mickhansen. This PR aims to solve the issue of fetching associations with data that was previously soft-deleted, using paranoid false on options. This problem was pointed out here. The issue was solved partially, the problem remained on other types of relationships. Here we are fixing the problem, adding and fixing some tests, and refactoring/linting some parts of the code. Please see the comments below.

mickhansen commented 4 years ago

Looks good, only a few comments. Solid work.

mickhansen commented 4 years ago

Published as v2.3.1 Thanks a lot for your contribution!