mickhansen / dataloader-sequelize

Batching and simplification of Sequelize with facebook/dataloader
MIT License
284 stars 58 forks source link

Resolve promise when sourcekey is null #132

Closed lewismclennan closed 2 years ago

lewismclennan commented 2 years ago

Been having issues when there is an empty relation on hasOne. The proposed change stops the loader being called when the foreign key is null. Which prevents the following error

The loader.load() function must be called with a value,but got: null.

This PR relates to the previously merged commit

https://github.com/mickhansen/dataloader-sequelize/pull/8/files

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.