search

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

Don't overwrite name of enum type if it already exists #501

Closed rogerso closed 4 years ago

rogerso commented 7 years ago

If a custom typeMapper already returns a custom enum type, attributeFields would overwrite that type's name with its own version, causing all sorts of problems (such as duplicated enum type definitions in the schema, which relay-compiler 1.1 does not like at all).

codecov-io commented 7 years ago

Codecov Report

Merging #501 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files          11       11           
  Lines         371      371           
=======================================
  Hits          344      344           
  Misses         27       27
Impacted Files Coverage Δ
src/attributeFields.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7a8865...56f5f01. Read the comment docs.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.