mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

Add field property to sequelizeConnection return value #577

Closed jedwards1211 closed 6 years ago

jedwards1211 commented 6 years ago

Now instead of wasting keystrokes with

    tasks: {
      type: userTaskConnection.connectionType,
      args: userTaskConnection.connectionArgs,
      resolve: userTaskConnection.resolve
    }

You can just write

  tasks: userTaskConnection.field

This PR leaves the connectionType and connectionArgs properties in place, and has no breaking changes.

codecov-io commented 6 years ago

Codecov Report

Merging #577 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #577   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          11       11           
  Lines         379      379           
=======================================
  Hits          360      360           
  Misses         19       19
Impacted Files Coverage Δ
src/relay.js 97.05% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d39d0ce...c61346f. Read the comment docs.

jedwards1211 commented 6 years ago

I think the timeouts in the CI tests are too low?

jedwards1211 commented 6 years ago

@mickhansen does it look good now?