search

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

support the alias name of field for order by #579

Closed flybluewolf closed 4 years ago

flybluewolf commented 6 years ago

support the alias name of field for order by in relay

mickhansen commented 6 years ago

Please follow the general code style. Please add a test covering this addition.

In addition to that, what's the general motivation? Sequelize already handles this.

codecov-io commented 6 years ago

Codecov Report

Merging #579 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   94.98%   95.03%   +0.05%     
==========================================
  Files          11       11              
  Lines         379      383       +4     
==========================================
+ Hits          360      364       +4     
  Misses         19       19
Impacted Files Coverage Δ
src/relay.js 97.14% <100%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d39d0ce...ed0ac62. Read the comment docs.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.