search

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

fix(defaultArgs): support compound primary keys #593

Closed jedwards1211 closed 6 years ago

jedwards1211 commented 6 years ago

fix #592

jedwards1211 commented 6 years ago

Seems like a transient CI test failure:

  1 failing
  1) relay should support after queries on connections:
      AssertionError: expected '0.0244309377324734' to equal '0.10437318821810226'
      + expected - actual
      -0.0244309377324734
      +0.10437318821810226
mickhansen commented 6 years ago

That failure is transient. But please add a new test covering this usecase.

codecov-io commented 6 years ago

Codecov Report

Merging #593 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
+ Coverage   94.98%   95.01%   +0.02%     
==========================================
  Files          11       11              
  Lines         379      381       +2     
==========================================
+ Hits          360      362       +2     
  Misses         19       19
Impacted Files Coverage Δ
src/defaultArgs.js 100% <100%> (ø) :arrow_up:
src/relay.js 97.03% <0%> (-0.03%) :arrow_down:
src/resolver.js 98% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d39d0ce...defa969. Read the comment docs.

jedwards1211 commented 6 years ago

@mickhansen okay I added a test. Btw, is there any reason you're not linting the test files?

jedwards1211 commented 6 years ago

@mickhansen transient failure again

mickhansen commented 6 years ago

@mickhansen okay I added a test. Btw, is there any reason you're not linting the test files?

No real reason, habit i guess.