search

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

fix(relay.js): fix faulty cursor strategy #597

Closed jedwards1211 closed 6 years ago

jedwards1211 commented 6 years ago

fix #596

mickhansen commented 6 years ago

Not sure why the original relay code uses a prefix: https://github.com/graphql/graphql-relay-js/blob/master/src/connection/arrayconnection.js#L149 - It should be irrelevant.

Your PR is not passing lint, travis is failing.

codecov-io commented 6 years ago

Codecov Report

Merging #597 into master will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   94.98%   94.93%   -0.06%     
==========================================
  Files          11       11              
  Lines         379      375       -4     
==========================================
- Hits          360      356       -4     
  Misses         19       19
Impacted Files Coverage Δ
src/relay.js 96.96% <100%> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d39d0ce...49c7bfc. Read the comment docs.

jedwards1211 commented 6 years ago

@mickhansen okay, I fixed the lint error