search

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

fix(relay): get item id for cursor properly #601

Closed jedwards1211 closed 6 years ago

jedwards1211 commented 6 years ago

fix #599 @intellix I made it at least check if it found the primaryKeyAttribute, and if not, use null for the id in the cursor. That should fix the long cursor problem with sequelize-typescript, but I can't think of an appropriate way to actually find the primaryKeyAttribute with sequelize-typescript, it's that package's responsibility to copy all static members from Sequelize's Model class over to its wrapper class.

jedwards1211 commented 6 years ago

@mickhansen one of the tests that's nondeterministic on postgres (according to comments in the code) failed again though I'm having a hard time seeing why it would be nondeterministic?

mickhansen commented 6 years ago

@jedwards1211 postgres sometimes decides to order things randomly, don't ask me why

mickhansen commented 6 years ago

v8.1.1