search

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

chore: test Node.js 6, 8 and 10 #602

Closed DanielRuf closed 6 years ago

DanielRuf commented 6 years ago

This should not have been merged yet.

We have to fix the unit tests and dependencies first.

DanielRuf commented 6 years ago

https://travis-ci.org/mickhansen/graphql-sequelize/builds/380592565

mickhansen commented 6 years ago

Ah my bad, i assumed it would just work on the future dialects actually.

DanielRuf commented 6 years ago

Ah my bad, i assumed it would just work on the future dialects actually.

Never assume that, especially as Node.js is relatively new and there are many projects which do not yet have binary builds for Node.js 10, eg sqlite 3 ;-)

And I see many projects which break with the current package.json files when Node.js 10 is added due to older dependencies.

mickhansen commented 6 years ago

Having the sqlite package in there at all is a bit of legacy i guess, don't really test against it anymore.

DanielRuf commented 6 years ago

Having the sqlite package in there at all is a bit of legacy i guess, don't really test against it anymore.

mocha $npm_package_options_mocha test/unit/*.test.js test/unit/**/*.test.js

/Users/druf/projects/graphql-sequelize/node_modules/sequelize/lib/dialects/sqlite/connection-manager.js:25
      throw new Error('Please install sqlite3 package manually');
      ^

Error: Please install sqlite3 package manually
    at new ConnectionManager (/Users/druf/projects/graphql-sequelize/node_modules/sequelize/lib/dialects/sqlite/connection-manager.js:25:13)
mickhansen commented 6 years ago

Hmm, that's odd for a unit test. Thanks for the fixes @DanielRuf