mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

Sequelize 4 symbol operators support. #606

Closed RichAyotte closed 6 years ago

RichAyotte commented 6 years ago

Fixes #585

codecov-io commented 6 years ago

Codecov Report

Merging #606 into master will decrease coverage by 0.88%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   95.01%   94.13%   -0.89%     
==========================================
  Files          11       12       +1     
  Lines         381      392      +11     
==========================================
+ Hits          362      369       +7     
- Misses         19       23       +4
Impacted Files Coverage Δ
src/resolver.js 98.03% <100%> (+0.03%) :arrow_up:
src/replaceWhereOperators.js 100% <100%> (ø) :arrow_up:
src/sequelizeOps.js 55.55% <55.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20305dd...3ff1d01. Read the comment docs.

RichAyotte commented 6 years ago

@mickhansen Let me know if there's anything that you'd like to see improved before merging. Thanks.

mickhansen commented 6 years ago

Looks good to me, just haven't been around, have you smoke tested this in your own project @RichAyotte?

RichAyotte commented 6 years ago

Yes, it's running with this patch in my project with Sequelize 4.37.10

mickhansen commented 6 years ago

v8.1.3