Closed RichAyotte closed 6 years ago
Merging #621 into master will decrease coverage by
2.46%
. The diff coverage is26.66%
.
@@ Coverage Diff @@
## master #621 +/- ##
=========================================
- Coverage 94.17% 91.7% -2.47%
=========================================
Files 12 13 +1
Lines 395 410 +15
=========================================
+ Hits 372 376 +4
- Misses 23 34 +11
Impacted Files | Coverage Δ | |
---|---|---|
src/typeMapper.js | 97.29% <100%> (+0.23%) |
:arrow_up: |
src/types/dateType.js | 8.33% <8.33%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d682a1b...fc4a819. Read the comment docs.
This will likely have to be considered a breaking change right? Remove yarn.lock
I'd definitely consider this a breaking change. Sorry about the yarn.lock, new PR coming.
The new DateType should be exported via src/index
Thanks for the review and quick merge!
The import is bad, the file name is "dateType" not DateType. I installed the module today and it failed because of that.
Error: Cannot find module './types/DateType'
at Function.Module._resolveFilename (module.js:547:15)
at Function.Module._load (module.js:474:25)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object.
PR is in the queue. https://github.com/mickhansen/graphql-sequelize/pull/622
Hopefully @mickhansen will merge it quickly.
ISO date format based off the code from https://github.com/mickhansen/graphql-sequelize/issues/166