mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

ISO date format support #621

Closed RichAyotte closed 6 years ago

RichAyotte commented 6 years ago

ISO date format based off the code from https://github.com/mickhansen/graphql-sequelize/issues/166

codecov-io commented 6 years ago

Codecov Report

Merging #621 into master will decrease coverage by 2.46%. The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #621      +/-   ##
=========================================
- Coverage   94.17%   91.7%   -2.47%     
=========================================
  Files          12      13       +1     
  Lines         395     410      +15     
=========================================
+ Hits          372     376       +4     
- Misses         23      34      +11
Impacted Files Coverage Δ
src/typeMapper.js 97.29% <100%> (+0.23%) :arrow_up:
src/types/dateType.js 8.33% <8.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d682a1b...fc4a819. Read the comment docs.

mickhansen commented 6 years ago

This will likely have to be considered a breaking change right? Remove yarn.lock

RichAyotte commented 6 years ago

I'd definitely consider this a breaking change. Sorry about the yarn.lock, new PR coming.

mickhansen commented 6 years ago

The new DateType should be exported via src/index

RichAyotte commented 6 years ago

Thanks for the review and quick merge!

mickhansen commented 6 years ago

https://github.com/mickhansen/graphql-sequelize/releases/tag/v9.0.0

darkrift commented 6 years ago

The import is bad, the file name is "dateType" not DateType. I installed the module today and it failed because of that.

Error: Cannot find module './types/DateType' at Function.Module._resolveFilename (module.js:547:15) at Function.Module._load (module.js:474:25) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at Object. (/home/rlavoie/work/kerozen/acry/backend/node_modules/graphql-sequelize/lib/index.js:17:13) at Module._compile (module.js:652:30) at Object.Module._extensions..js (module.js:663:10) at Module.load (module.js:565:32) at tryModuleLoad (module.js:505:12) at Function.Module._load (module.js:497:3) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at Object. (/home/rlavoie/work/kerozen/acry/backend/schema/types/root_query_type.js:2:20) at Module._compile (module.js:652:30) at Object.Module._extensions..js (module.js:663:10) at Module.load (module.js:565:32) at tryModuleLoad (module.js:505:12) at Function.Module._load (module.js:497:3) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at Object. (/home/rlavoie/work/kerozen/acry/backend/schema/index.js:2:23) at Module._compile (module.js:652:30)

RichAyotte commented 6 years ago

PR is in the queue. https://github.com/mickhansen/graphql-sequelize/pull/622

darkrift commented 6 years ago

Hopefully @mickhansen will merge it quickly.