intellix commented 5 years ago

Partially resolves #639

I thought we could resolve it by just allowing either String or EnumType but let me know if you'd prefer a separate parameter. I could document this Behaviour in relay.md

intellix commented 5 years ago

Strange that it passed locally and can see 10 passed but the other errors for Node 6/8 don't seem to make sense to me. Flake?

mickhansen commented 5 years ago

Yeah most of the runs pass, there's some flaky stuff for Postgres i haven't bothered to completely fix.

codecov-io commented 5 years ago

Codecov Report

Merging #642 into master will increase coverage by 0.02%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
+ Coverage    91.5%   91.52%   +0.02%     
==========================================
  Files          13       13              
  Lines         412      413       +1     
==========================================
+ Hits          377      378       +1     
  Misses         35       35

Impacted Files	Coverage Δ
src/relay.js	`97.12% <100%> (+0.02%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d392090...334614a. Read the comment docs.

mickhansen commented 5 years ago

v9.1.0

mickhansen / graphql-sequelize

Add support for passing orderBy by type name #642

Codecov Report