search

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

Use Buffer.from #662

Closed jonmagic closed 4 years ago

jonmagic commented 5 years ago

I was receiving deprecation notices when using with Node 10: https://nodesource.com/blog/understanding-the-buffer-deprecation-in-node-js-10/

codecov-io commented 5 years ago

Codecov Report

Merging #662 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files          13       13           
  Lines         426      426           
=======================================
  Hits          389      389           
  Misses         37       37
Impacted Files Coverage Δ
src/base64.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbf74bd...23d0218. Read the comment docs.

jonmagic commented 5 years ago

Is this a flaky test or did I actually break something with this change? Not sure how to re-run CI to find out.