search

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

Replace `_.assign` on `Object.assign` #664

Closed dmshvetsov closed 5 years ago

dmshvetsov commented 5 years ago

This change is aimed to remove ambiguity.

Use Object.assign in Readme in examples because not everyone knows about lodash package, someone knows that _ is underscore package, _ is not required/imported explicitly.

codecov-io commented 5 years ago

Codecov Report

Merging #664 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files          13       13           
  Lines         426      426           
=======================================
  Hits          389      389           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 248b244...9dc0222. Read the comment docs.

mickhansen commented 5 years ago

Thanks @shvetsovdm