search

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize
MIT License
1.9k stars 172 forks source link

Implemented support for multiple fields on orderBy #693

Closed Yehonal closed 4 years ago

Yehonal commented 4 years ago

It will fix: https://github.com/mickhansen/graphql-sequelize/issues/356

mickhansen commented 4 years ago

As i commented in the original thread i would suggest people rely on using something more graphql idiomatic (enums) than sending in arbitrary strings.

Yehonal commented 4 years ago

As i commented in the original thread i would suggest people rely on using something more graphql idiomatic (enums) than sending in arbitrary strings.

This imply to change the type of order argument, is it right?

This will break compatibility with old code, instead such change is legacy and just allows you to do the following:

"reverse:field1,reverse:field2,field3" etc...

Keeping the current syntax. Then in ver 9.5 or 10 you can change this behaviour.

What do you think?

Yehonal commented 4 years ago

PS travis error are not related to this change, I guess

 AssertionError: expected '0.18102374714205038' to equal '0.9222949639571385'
      + expected - actual
      -0.18102374714205038
      +0.9222949639571385
stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.