Update graphql/graphql-relay and add support for Sequelize 6

mickhansen / graphql-sequelize

GraphQL & Relay for MySQL & Postgres via Sequelize

MIT License

1.9k stars 172 forks source link

Update graphql/graphql-relay and add support for Sequelize 6 #715

Closed intellix closed 1 year ago

intellix commented 1 year ago

Was hoping to update to Apollo Server 4 and noticed a plethora of peer dependencies getting angry. Noticed that the peer deps here were quite old. Tried:

[x] Unit tests passing
[x] Integration tests passing

intellix commented 1 year ago

to be honest this is even more difficult. I don't think the unit tests pass in Sequelize 3 which are required in devDeps due to instanceof failures in the typeMapper:

sequelizeType instanceof CHAR

If I install Sequelize 6 for testing locally, then I get Promise errors as it expects bluebird which is no longer there...

mickhansen commented 1 year ago

@intellix I'd be fine with dropping the legacy support, can publish as a major. The project needs some maintenance of dependencies, running tests is troublesome yes.

intellix commented 1 year ago

ok all unit and integration tests now pass with:

graphql-relay@^0.10 and graphql@^16
graphql-relay@^0.9 and graphql@^0.13 || graphql@^14 || graphql@^15

And Sequelize v6+ supported for dataloading (due to the constructor.options and findByPk changes)

mickhansen commented 1 year ago

Awesome work @intellix, thank you!

mickhansen commented 1 year ago

Released: https://github.com/mickhansen/graphql-sequelize/releases/tag/v9.5.0

intellix commented 1 year ago

I'm not sure if it's just me, but it seems like the npm package is mostly empty and missing files:

mickhansen commented 1 year ago

@intellix Sorry about that, didn't realize this repo didn't have a prepublish script, please try 9.5.1