Support AEM 6.1 SP2 & Fixed warning

mickleroy / aem-sass-compiler

Enable Sass support for AEM

Other

49 stars 18 forks source link

Support AEM 6.1 SP2 & Fixed warning #5

Closed stomx closed 7 years ago

stomx commented 7 years ago

It can support AEM6.1 SP2. I modified the warning. The Tab character was replaced by Space.

mickleroy commented 7 years ago

Hi @StomX, thanks for the pull request! 👍

I'll be away this weekend so won't have time to look into it but at a glance, the following need to be addressed:

the indentation needs to be kept to 4 spaces
the unit tests need to be passing

After this is done, I will test it and get you to merge it into a 6.1 specific branch that I will create once I've had time to think about a branching strategy for AEM versions.

mickleroy commented 7 years ago

Unfortunately, getting the compiler working in 6.1 wasn't as easy as downgrading the uber jar version. The problem I ran into was a VerifyError in the com.adobe.granite.ui.clientlibs.script.Utils class when using the 6.1 uber jar.

I was only able to get this working with 6.1 SP2 and I've created release 0.9.0 for AEM 6.1 SP2 support.