mickorz / rtmplite

Automatically exported from code.google.com/p/rtmplite
1 stars 0 forks source link

Fix H264 translation from RTP to RTMP for naltype=28 #69

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The implemented translation of H264 for naltype=28 (fragmentation) is not 
correct. Although it works with Bria 3 and ekiga when they send packetization 
mode 0 (no fragmentation) it won't work if they send packetization mode 1. The 
reason is that a number of processing depends on intra-frame in _rtp2rtmpH264 
function of siprtmp.py. But if naltype=28, those processing are not done. 
Ideally, if naltype=28, you should first collect all the fragments and 
construct the original naltype. And if original naltype is 5, then do those 
processing. 

Original issue reported on code.google.com by kundan10 on 29 Jan 2012 at 6:39

GoogleCodeExporter commented 9 years ago
Fixed in r146. Need to test with SIP clients that actually send nal type 28 and 
24.

Original comment by kundan10 on 22 Feb 2012 at 3:21