search

mickstar / Zoo-For-Zotero

This is an Android app for viewing Zotero libraries.
574 stars 54 forks source link

PDFs downloaded but not opened #38

Closed GeorgRamer closed 4 years ago

GeorgRamer commented 4 years ago

Let me start by saying how great the app already is! Thank you for taking the time writing it!

The only issue that I have with it right now is that PDFs are downloaded (and stored on the device) but not opened. The files are stored inside of cryptically named folders in my download folder so they are quite hard to find after downloading, too. Is this the expected behaviour?

mickstar commented 4 years ago

No, the app should open the PDFs upon downloading/tapping. There is a bug with Huawei devices whereby they don't respect the android standard for opening files and just crash. https://stackoverflow.com/questions/53853044/i-could-not-choose-pdf-file-in-android-8-oreo-huawei describes the problem. The main solution seems to be copying the file to the app folder after downloading which seems wasteful but i will implement this solution for the next update. also this "solution" will break pdf annotations so im unsure about it, though it is only like 5 users experiencing it

Regarding the folder structure, i recently changed it to mirror the Zotero desktop clients, which is {itemkey}/attachment.pdf . The reason for this change is for users that wish to copy/sync their zotero's folder to their device so they can access the PDFs without downloading.

dbonattoj commented 4 years ago

Hello there, Very nice app!

I'm not sure it is the issue here, I have the same bahaviour in Samsung Galaxy Tab s3! At the moment I go to the folder by hand and find the PDFs.

Is there a way to access application log files?

Thanks for the good work!

mickstar commented 4 years ago

Yes, you could connect it to a computer and use logcat or try one of the logcat apps on the Play store.

So as I'm understanding it, the app downloads attachments but doesn't open them? And there is a pdf reader app installed?

On Fri, 20 Dec. 2019, 20:11 dbonattoj, notifications@github.com wrote:

Hello there, Very nice app!

I'm not sure it is the issue here, I have the same bahaviour in Samsung Galaxy Tab s3! At the moment I go to the folder by hand and find the PDFs.

Is there a way to access application log files?

Thanks for the good work!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mickstar/Zoo-For-Zotero/issues/38?email_source=notifications&email_token=AAAV2V7DOUWL7DF6RSGHRPDQZSD25A5CNFSM4J5DH7DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHMLRKY#issuecomment-567851179, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAV2V2FMJPPS6QAEVU3KADQZSD25ANCNFSM4J5DH7DA .

GeorgRamer commented 4 years ago

Yes. There is a pdf reader app installed. I am on a Pixel 2, if that helps. I will see what logcat outputs and the report back.

On Fri, Dec 20, 2019, 09:27 Michael Johnston notifications@github.com wrote:

Yes, you could connect it to a computer and use logcat or try one of the logcat apps on the Play store.

So as I'm understanding it, the app downloads attachments but doesn't open them? And there is a pdf reader app installed?

On Fri, 20 Dec. 2019, 20:11 dbonattoj, notifications@github.com wrote:

Hello there, Very nice app!

I'm not sure it is the issue here, I have the same bahaviour in Samsung Galaxy Tab s3! At the moment I go to the folder by hand and find the PDFs.

Is there a way to access application log files?

Thanks for the good work!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/mickstar/Zoo-For-Zotero/issues/38?email_source=notifications&email_token=AAAV2V7DOUWL7DF6RSGHRPDQZSD25A5CNFSM4J5DH7DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHMLRKY#issuecomment-567851179 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAV2V2FMJPPS6QAEVU3KADQZSD25ANCNFSM4J5DH7DA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mickstar/Zoo-For-Zotero/issues/38?email_source=notifications&email_token=ACJG7M4VF5JOW4HUH6JJU6DQZSFYVA5CNFSM4J5DH7DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHMM4AQ#issuecomment-567856642, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJG7M5LYOLJHKM72462WHTQZSFYVANCNFSM4J5DH7DA .

mickstar commented 4 years ago

oops found the bug, it occurs when webdav is enable and was due to bad logic fixed in 531f70b8cde9d56c26c7e59ea40e7bcf38cbf059

traits commented 4 years ago

Regarding the folder structure, i recently changed it to mirror the Zotero desktop clients, which is {itemkey}/attachment.pdf . The reason for this change is for users that wish to copy/sync their zotero's folder to their device so they can access the PDFs without downloading.

This is a good thing. It makes a satisfying workaround for me regarding webdav (#33) issues. Please don't change this.