micku7zu / QuickCursor

Quick Cursor: One-Handed mode
https://play.google.com/store/apps/details?id=com.quickcursor
20 stars 1 forks source link

Change brightness action doesn't work correctly on Samsung devices with Adaptive brightness turned on #14

Open micku7zu opened 1 year ago

micku7zu commented 1 year ago

Issue description

The "Change brightness" action doesn't work correctly on Samsung devices with Adaptive brightness turned on.

The action changes the brightness to the correct value but the screen brightness it is not changed, or it is changed really slow.

This is a bug from Samsung and can be reproduced with ADB:

  1. Turn on Adaptive brightness
  2. Set the screen brightness with ADB command adb shell settings put system screen_brightness 255 adb shell settings put system screen_brightness 0
  3. The brightness setting will be changed but the actual screen brightness it is not changed, or it is changed really really slow.

Workaround

The only workaround found yet it is to disable the "Adaptive brightness".

There are possible fixes that can be implemented in Quick Cursor but all of them are hacks that are hard to support:

  1. Make Quick Cursor disable adaptive brightness first, and then change the brightness, and then enable adaptive brightness back when the device it is locked. This is a hack that would work but it is hard to support and it can create confussions
  2. Make Quick Cursor change the brightness really slow and repeatedly from value X to Y, by increasing/decreasing the brightness by 1 at a time. I've implemented this but it is a bad user experience that it is hard to support (to explain to users why it works so bad).

So currently there is no acceptable solution to implement in Quick Cursor.