micku7zu / QuickCursor

Quick Cursor: One-Handed mode
https://play.google.com/store/apps/details?id=com.quickcursor
20 stars 1 forks source link

"Change brightness" action doesn't set the brightness to lowest or highest value #18

Closed micku7zu closed 1 year ago

micku7zu commented 1 year ago

Issue description

The "Change brightness" action doesn't work correctly because the minimum brightness or maximum brightness is not enough

The root cause

According to Android documentation, the "screen_brightness" Android setting must be an integer value between 0 - 255

This can be tested using ADB:

adb shell settings put system screen_brightness 0
adb shell settings put system screen_brightness 1
adb shell settings put system screen_brightness 25
adb shell settings put system screen_brightness 150
adb shell settings put system screen_brightness 255

The Android documentation is pretty easy and clear, but the documentation is not respected, and in reality, the screen_brightness range is different between Android versions and different manufacturers.

And after some feedback from users and debug, there are some exceptions and complications that are not specified anywhere:

micku7zu commented 1 year ago

This issue was fixed in Release 1.22.6 (version 188) by adding a calibration tool:

Calibration tool:

https://user-images.githubusercontent.com/3103859/230988712-9073b6f5-16b8-4d13-8e5c-560c9f1a5809.mp4