miclav / mapcrafter

High Performance Minecraft Map Renderer.
http://mapcrafter.org
GNU General Public License v3.0
123 stars 23 forks source link

Solid blocks appear way too dark #28

Open alexanderneuschl opened 3 months ago

alexanderneuschl commented 3 months ago

Hey there! @miclav, you're the GOAT for keeping this project alive, thanks.

Last year, I rendered a map with a 1.19 world which worked like a charm. However, this year I decided to try it again with a 1.20 world. I checked out your "world120" branch on my server and built the images on there.

The (relevant part of the) docker-compose.yml I use:

mapcrafter:
    build:
        context: mapcrafter-world120/
    volumes:
        - /home/.../mc/world:/world:ro
        - /home/.../mcmap:/output
        - /home/.../mapcrafter/config:/config
    command: -c /config/render.conf -j 6

Here's my (full) config:

output_dir = /output
background_color = #000000

[world:world]
input_dir = /world
dimension = overworld
crop_center_x = 0
crop_center_z = 0
crop_radius = 4000

[world:world_full]
input_dir = /world
dimension = overworld

[global:map]
world = world
render_view = isometric
render_mode = daylight
rotations = top-left top-right bottom-right bottom-left

[map:map_world_day]
name = 3D, Tag

And everything seems to work fine, except for some blocks. Solid blocks are rendered way too dark. This is the output as seen on the output website: render

At first I thought the textures weren't loaded correctly, however when I increase the brightness in the dark areas, the textures are suddenly visible. render_bright

Thank you!

THElib03 commented 2 months ago

Was this in 1.20.6? I'm having the same issue in 1.21 but back in 1.20.4 it worked fine

alexanderneuschl commented 1 month ago

The world I tried to render was 1.20.4.

miclav commented 1 month ago

Hi Sorry for the mix up. I tried recently to implement an antialias during block production. The result was not to expectations, so didn't publish the result in blockcrafter project, however I produced the 1.21 block update with this test branch by mistake, so it produced the issues you ended up with. That's my bad. I'll publish the correct ones during the day. My apologies

miclav commented 1 month ago

All looks back to normal now. Really sorry for this mistake. image