deseilligny
commented
1 year ago Je manque un peu de contexte, cela dit je vois pas cette ligne dans les ElFifo
De: "JM Muller" @.> À: "micmacIGN/micmac" @.> Cc: "Marc Pierrot-Deseilligny" @.>, "Review requested" @.> Envoyé: Jeudi 17 Août 2023 15:01:42 Objet: Re: [micmacIGN/micmac] Fix GCC 12.1.0 compilation with -Werror (PR #197)
@jmmuller commented on this pull request.
In [ https://github.com/micmacIGN/micmac/pull/197#discussion_r1296904213 | include/ext_stl/fifo.h ] :
@@ -197,6 +197,9 @@ template
class ElFifo
void incr_capa()
{- if (_capa == 0)
Should be if (_capa < 1) _capa = 1;
in constructor?
In [ https://github.com/micmacIGN/micmac/pull/197#discussion_r1296908050 | src/uti_phgrm/GraphCut/QPBO-v1.4/QPBO.cpp ] :
@@ -202,7 +202,7 @@ template
node_max[1] = nodes[1] + node_num_max; if (stage) {
- memmove(nodes[1], (char)nodes[0] + ((char)nodes_old[1] - (char)nodes_old[0]), node_numsizeof(Node));
Why not declaring size here?
— Reply to this email directly, [ https://github.com/micmacIGN/micmac/pull/197#pullrequestreview-1582131015 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AFROVJQIAXQPAVFIGPIDJD3XVYI3NANCNFSM5YNVEMPA | unsubscribe ] . You are receiving this because your review was requested. Message ID: @.***>
jmmuller
Mostly "maybe uninitialized" variable making the compilator not happy and use of pointer arithmetic with freed pointer which trigger compilation warning/error.
Need to check if graph cut reallocation code still used. If yes need to insure that the old freed pointer not used to suppress the compilation error.
Maybe others compiler will trigger other errors.