micmro / PerfCascade

Responsive, SVG based HAR waterfall viewer
https://micmro.github.io/PerfCascade
MIT License
276 stars 51 forks source link

Responses with HTTP status code of 0 not highlighted #267

Closed JonathanWylie closed 3 years ago

JonathanWylie commented 4 years ago

When displaying a HAR when a component did not get a response, eg connection refused, or connection timeout etc then the http status code defaults to 0. I would like perf cascade to highlight them when displaying the har, so it is clear there was a problem. Then I will put the reason, eg connection timeout, in the "comment", so the user can easily there was a problem with the component and what the cause was. Or perhaps use the indicators for this, so indicate it with the error icon, if it has a status code of 0, and if it has a comment, include that in the error message.

I am willing to make a pull request if this behaviour is wanted.

micmro commented 3 years ago

@JonathanWylie I've setup a PR (#277) to address this (screenshot below), but used a manually changed HAR file, do you have any real-world examples? I assume the "comment" you mentioned would be in the the statusText field?

Screen Shot 2021-04-18 at 1 48 14 PM
micmro commented 3 years ago

Released with 2.9.0