search

micmro / PerfCascade

Responsive, SVG based HAR waterfall viewer
https://micmro.github.io/PerfCascade
MIT License
276 stars 51 forks source link

[WIP] Support chunks in HTTP2 Fixes #237 #282

Closed radum closed 3 years ago

radum commented 3 years ago

This the work I have done for fix #237. Is not yet finished.

radum commented 3 years ago

@soulgalore I guess we can continue our conversation from #237 here to this over the finish line 😁

In theory everything works as it is, you can see the chunks rendering, but needs to be tested with some edge cases I guess.

Also the har entry interface is missing the chunks key so that will fail TS if we use it. We either have to copy and keep our own version of we raise it with them and hope it gets merged.

soulgalore commented 3 years ago

Great thank you @radum ! I have a look later this weekend.

soulgalore commented 3 years ago

@radum this looks good for me, was there something special you where thinking that needed to be fixed? I think the 1px instead of the "correct" width is fine, it will still help Ito show when content is sent?

radum commented 3 years ago

Apart from that I can't think of anything else @soulgalore. I just wanted to test it using lots of examples to make sure it works fine.

As for the 1px issue, yeah for sure it is better than nothing and I think still valuable. Not sure what will be the best way to bring the correct width in though. Although we can incrementally bring that in at a later date.

soulgalore commented 3 years ago

Works fine for me too, @micmro is it ok for you so we can merge/release it?

micmro commented 3 years ago

@radum would you mind updating @types/har-format to 1.2.8 to fix the _chunk type?

radum commented 3 years ago

@micmro Done. Not sure if you want to change the colors to look a bit better when the chunks are present. I think the contrast should be reversed. The light shade should be the bar and the dark one the chunks.

micmro commented 3 years ago

Thanks a lot @radum! I'll merge it and play around with the colours a bit and cut a new release after.

micmro commented 3 years ago

Released with 2.11.0