x-axis value disappearing in waterfall model representation of page load

micmro / PerfCascade

Responsive, SVG based HAR waterfall viewer

https://micmro.github.io/PerfCascade

MIT License

272 stars 51 forks source link

x-axis value disappearing in waterfall model representation of page load #288

Closed manjunathpremkumar closed 1 year ago

manjunathpremkumar commented 2 years ago

Hi,

We noticed that in our one of scripted journey test, x-axis values (in seconds) are not appearing for waterfall model representation of page load. We are able to reproduce this issue multiple times. Attached the HAR file for the page loaded and screenshot of the issue.

IBE_Guest_PassengerDetails_Page_Load-chrome-2022-09-07183603.har.gz X-axis Note: This is happening for this particular user journey and not for other journeys.

manjunathpremkumar commented 2 years ago

@soulgalore - by any chance you got time to see this issue, I know you will be super occupied :)

micmro commented 1 year ago

Looks like this has to do with floating point precision in this function: https://github.com/micmro/PerfCascade/blob/main/src/ts/waterfall/sub-components/svg-general-components.ts#L71-L85

Will dig into this more durning the weekend.

micmro commented 1 year ago

Fixed with 3.0.3

micmro commented 1 year ago

manjunathpremkumar commented 1 year ago

Thanks a lot!