search

micnews / react-jw-player

A React Component API for JW Player
195 stars 94 forks source link

deep comparison for playlist #105

Closed bennidhamma closed 6 years ago

bennidhamma commented 6 years ago

we are regenerating a playlist via redux that ends up being identical contents, just a fresh object.

seems reasonable to do a deep comparison here, instead of a shallow equality test.

otherwise this code resets the player mid stream for us if that playlist prop gets touched.

ellell commented 6 years ago

Nice, thank you for this!

bennidhamma commented 5 years ago

my pleasure! happy to give back!