search

micnews / rpc-http

simple rpc over http
Other
5 stars 0 forks source link

Support Buffers, RegExps & Dates except pure JSON #2

Closed kesla closed 10 years ago

kesla commented 10 years ago

This is a breaking change, so will lead to a 3.0.0

Have I missed any times?

juliangruber commented 10 years ago

lgtm in general, but maybe we could use a module to encode all those different values, i'm pretty sure there's a couple extended json modules

dominictarr commented 10 years ago

I agree with @juliangruber encoding should be a user option - if you are gonna use non-standard json it should be refactored out to it's own module.

juliangruber commented 10 years ago

i meant to use a module inside rpc-http, to keep the code simpler, but yeah i agree with @dominictarr

kesla commented 10 years ago

Thanks for feedback. Will extract and add as a user-options, per @dominictarr's suggestion.

kesla commented 10 years ago

I'm closing this and create a new PR with support for custom encodings. Has extracted the none-json stuff from here to https://github.com/micnews/json-extended