nigiord commented 3 years ago

…type and level when building a zipped database. Default behavior stays the same (ZIP_STORED with no compression).

This commit reworks the behavior of the compress parameter and adds the optional parameter compresslevel to micom.workflows.build_database().

codecov[bot] commented 3 years ago

Codecov Report

Merging #39 (4fc3e27) into master (5101fed) will decrease coverage by 0.14%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   76.93%   76.79%   -0.15%     
==========================================
  Files          30       30              
  Lines        1860     1866       +6     
  Branches      346      348       +2     
==========================================
+ Hits         1431     1433       +2     
- Misses        304      306       +2     
- Partials      125      127       +2

Impacted Files	Coverage Δ
micom/workflows/build.py	`91.25% <60.00%> (-4.70%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5101fed...4fc3e27. Read the comment docs.

nigiord commented 3 years ago

Hi @cdiener, sorry I was quite busy those last weeks at work, but I'm not abandonning this PR. I'm gonna take time to address all your points .

cdiener commented 3 years ago

No worries. I definitely understand. Thanks for helping to improve MICOM :smile:

nigiord commented 3 years ago

Hi @cdiener, thank you for your patience. I addressed all issues, let me know what you think.

Cheers, Nils

cdiener commented 3 years ago

Awesome, that looks good. The failing tests are unrelated, just need to update the Qiime test files. I'll add those to the PR and merge it afterwards. Thanks!

micom-dev / micom

Fix #37 by allowing the user to define the compression... #39

Codecov Report