micro-ROS / micro-ROS-Agent

ROS 2 package using Micro XRCE-DDS Agent.
Apache License 2.0
97 stars 51 forks source link

Fix/snap #141

Closed Guillaumebeuzeboc closed 2 years ago

Guillaumebeuzeboc commented 2 years ago

What this PR includes:

In order to automatically upload the snap, the secret STORE_LOGIN must be defined. On snapcraft.io the snap is owned by eProsima, hence, the owner of this account should follow this procedure:

Moving a released snap from candidate to stable can be done with the snapstore by the eProsima account.

Note that releasing the snap from candidate to stable should be done manually on the store after proper testing.

The final snap has been tested with a serial micro-ros device

Closes https://github.com/micro-ROS/micro-ROS-Agent/issues/63

Acuadros95 commented 2 years ago

Well, should have tested the arm64 version. It looks like we can't build for arm64 here, check the amd64 name on the arm job: micro-ros-agent_0+git.7852fa4_amd64.snap

I am trying to fix it here: https://github.com/micro-ROS/micro-ROS-Agent/pull/151. But it looks like it cannot be archieved using snapcore/action-build

Guillaumebeuzeboc commented 2 years ago

Indeed I didn't see that. From what I could read we are supposed to use https://github.com/diddlesnaps/snapcraft-multiarch-action But there is a bug right now https://github.com/diddlesnaps/snapcraft-multiarch-action/issues/6

I would suggest disabling the arm64 build for now.

Let me know if you want me to open a PR