search

micro-ROS / micro-ROS-Agent

ROS 2 package using Micro XRCE-DDS Agent.
Apache License 2.0
101 stars 58 forks source link

Fix/snap version #162

Closed Guillaumebeuzeboc closed 1 year ago

Guillaumebeuzeboc commented 2 years ago

Hello,

I realized that the version and grade of the foxy snap was not set properly.

Version and grade are set programmatically from the uros-agent part, hence were conflicting with the ones hard coded in the YAML. Also, we need the full git history in the action, so we can get the last tagged version when releasing a non-tagged version (So the name can be tag+git-COMMITHASH)

pablogs9 commented 1 year ago

@Guillaumebeuzeboc thanks for that, I'm working on repairing the build of this snap package. One question: shall this be backported to main?

Guillaumebeuzeboc commented 1 year ago

@pablogs9 , it should be, yes. But first the snapcraft.yaml as well as the build should be ported to humble. I will open a PR for that.

pablogs9 commented 1 year ago

Thanks!