search

micro-ROS / micro-ROS-Agent

ROS 2 package using Micro XRCE-DDS Agent.
Apache License 2.0
104 stars 62 forks source link

Parameters not working in Iron through cli #195

Closed rosterloh closed 1 year ago

rosterloh commented 1 year ago

Describe the bug Using get|set|dump from the ros2 cli fails with Wait for service timed out waiting for parameter services for node /micro_ros_node. If you attempt to get or set parameters in code this works successfully.

To Reproduce Steps to reproduce the behaviour:

  1. Create micro-ROS application with parameter server like this
  2. Connect the agent
  3. Run ros2 param dump esp32_param_node
  4. See error Wait for service timed out waiting for parameter services for node /esp32_param_node

Expected behaviour ros2 param cli commands work as expected the same as non micro-ROS nodes

System information (please complete the following information):

pablogs9 commented 1 year ago

Hey @rosterloh, we are currently releasing and testing Iron for micro-ROS, the official release is not already out.

CC: @Acuadros95 PTAL

rosterloh commented 1 year ago

@pablogs9 I completely understand. I just saw you were working on it so I thought I'd bring it up while you were busy. I'd happily help test or work on anything for you if it helps.

Acuadros95 commented 1 year ago

We were missing a parameter service on the micro-ROS client side, that is the reason for the Wait for service timed out waiting for parameter services message.

@rosterloh Thanks for checking this! This PR will solve the issue: https://github.com/ros2/rclc/pull/354

rosterloh commented 1 year ago

Amazing thanks @Acuadros95!

Acuadros95 commented 1 year ago

Closing as https://github.com/ros2/rclc/pull/354 is merged!