search

micro-ROS / micro-ROS-Agent

ROS 2 package using Micro XRCE-DDS Agent.
Apache License 2.0
97 stars 51 forks source link

Use fastcdr-2.2.x for ROS 2 Rolling #225

Closed srmainwaring closed 1 month ago

srmainwaring commented 1 month ago

Fixes https://github.com/micro-ROS/micro-ROS-Agent/issues/223 for rolling.

Would be good to have a jazzy branch now that it has been released.

pablogs9 commented 1 month ago

Please check CI

srmainwaring commented 1 month ago

Please check CI

CI on an Ubuntu 22 image is not going to work because the upstream package for fastcdr 2.2.x is not available. We'll need a jazzy branch and a custom CI workflow for that please. If you create the branch I'm happy to set up the CI workflow.

At the moment micro-ROS will not work with ROS 2 Jazzy. It is also a problem on RPi as the default image for Ubuntu server is now 24.04.

hippo5329 commented 1 month ago

How about add the conditional compilation by checking the fastcdr version? Then we can have one source for fastcdr v1 and v2. Jazzy will need additional ci.

pablogs9 commented 1 month ago

Can we consider this superseded by https://github.com/micro-ROS/micro-ROS-Agent/pull/226 ?

srmainwaring commented 1 month ago

Can we consider this superseded by #226 ?

Sure, #226 is identical with the addition of the workflow update.