search

micro-ROS / micro_ros_diagnostics

Diagnostics framework for micro-ROS
Apache License 2.0
8 stars 4 forks source link

Cmake option to enable/disable building examples #18

Closed norro closed 3 years ago

norro commented 3 years ago

Also documented, which packages go on the uC and which go on the uP. /cc @bjv-capra

Signed-off-by: Nordmann Arne (CR/ADT3) arne.nordmann@de.bosch.com

bjv-capra commented 3 years ago

I'll check it out now

bjv-capra commented 3 years ago

Regarding the common_diagnostics, do we leave it building the executable (hwmonitor) by default? As a user, I don't know how I'd link an executable to my embedded project. Isn't it basically another example one can run on your i.e. Linux system. Thus, needs to be disabled?

norro commented 3 years ago

For now the common diagnostics package is not of much use, agreed. The intention is to at some point in time indeed provide common diagnostics/monitors, e.g., a heap monitor for ESP32. If this is the case (hopefully soon), it will have several configuration options depending on the actual hardware and OS.

I am fine with disabling the package for now (AMENT_IGNORE/COLCON_IGNORE), if this makes things easier. Would that help?

bjv-capra commented 3 years ago

If that's the intention, it's okay. The PR builds fine and I have no more comments :) Thanks for it

norro commented 3 years ago

Thanks for your feedback and comments! Now merging...