micro-ROS / micro_ros_diagnostics

Diagnostics framework for micro-ROS
Apache License 2.0
8 stars 4 forks source link

Updater topic name can be remapped via CMAKE #32

Closed bjv-capra closed 2 years ago

bjv-capra commented 2 years ago

closes https://github.com/micro-ROS/micro_ros_diagnostics/issues/19

@norro I took the liberty of creating a PR with what we discussed.

codecov-commenter commented 2 years ago

Codecov Report

Merging #32 (01a9573) into master (c1a9f53) will decrease coverage by 0.49%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   39.02%   38.52%   -0.50%     
==========================================
  Files           2        2              
  Lines         123      122       -1     
  Branches       19       19              
==========================================
- Hits           48       47       -1     
  Misses         61       61              
  Partials       14       14              
Impacted Files Coverage Δ
..._diagnostic_updater/micro_ros_diagnostic_updater.c 71.21% <ø> (-0.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1a9f53...01a9573. Read the comment docs.

bjv-capra commented 2 years ago

If it's okay with you, I could try to cover both (bridge and updater) on this PR.

bjv-capra commented 2 years ago

@norro This PR is ready for review (Still needs documentation updates)

What I did is to

`/diagnostics` -> `diagnostics`
`/diagnostucs_uros` -> `diagnostics`

Let me know what you think

bjv-capra commented 2 years ago

@norro this PR is ready

bjv-capra commented 2 years ago

@norro friendly ping. I can't merge until you remove your "changes requested" :)