micro-ROS / micro_ros_renesas_demos

Demo code for Renesas e2 studio
Apache License 2.0
4 stars 5 forks source link

Demo 3 Parameter Server not working #85

Closed Jackogip closed 1 year ago

Jackogip commented 1 year ago

Issue template

Steps to reproduce the issue

Expected behavior

Additional information

The node is showing up as /my_renesas_node and the code is executing fine and getting to the while loop.

When running ros2 node info /my_renesas_node -- I get the following:

/my_renesas_node
  Subscribers:

  Publishers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
  Service Servers:
    /my_renesas_node/get_parameters: rcl_interfaces/srv/GetParameters
  Service Clients:

  Action Servers:

  Action Clients:
Acuadros95 commented 1 year ago

The memory configuration file was missing: detail.

I have updated the demo branch with the correct configuration and also upgrade it to Humble. This adds improvements in the parameter server callback, check them out in the micro-ROS app file.

For more details on the parameter server update, you can check this documentation: link. Focus on the micro-ROS Humble section.

Jackogip commented 1 year ago

@Acuadros95 When running this project now I get: 'RCLC_EXECUTOR_PARAMETER_SERVER_HANDLES' undeclared (first use of this function)

This is odd since the rclc_parameter.h is included and RCLC_EXECUTOR_PARAMETER_SERVER_HANDLES is there.

Any ideas on what the issue might be?

Acuadros95 commented 1 year ago

Just tested it locally and it builds, some ideas:

Jackogip commented 1 year ago

Thanks this worked.

I was working from an older version - sorry for that :)

Jackogip commented 1 year ago

Hi @Acuadros95

I'm trying to use the UART version of demo 3 now and I'm having a similar issue when compiling I'm getting the following errors at the 'create executor':

RCLC_EXECUTOR_PARAMETER_SERVER_HANDLES' undeclared (first use in this function) & error: passing argument 3 of 'rclc_executor_add_parameter_server' from incompatible pointer type [-Werror=incompatible-pointer-types]

I've pulled the latest foxy files and tried to go through the steps above but still having this issue.

Any ideas?

Acuadros95 commented 1 year ago

I've pulled the latest foxy files and tried to go through the steps above but still having this issue.

You should use the commit that is on the repository.

This new paremeter API works targets micro-ROS Humble, but you should not encounter problems communicating with ROS2 foxy.