Adjust zephyr headers for udp

micro-ROS / micro_ros_zephyr_module

micro-ROS Zephyr module and sample code

Apache License 2.0

46 stars 22 forks source link

Adjust zephyr headers for udp #108

Closed gseqBE closed 1 year ago

gseqBE commented 1 year ago

With posix enabled for UDP, the heads for zephyr 3.1 and 3.2, seem off. Corrected headers in PR.

pablogs9 commented 1 year ago

Is this making the Zephyr module fail? Can you provide details about which is the problem? Is possible to add this as conditional compilation only when POSIX is enabled?

gseqBE commented 1 year ago

The base example for the micro ros module does not have a udp example. The moment UDP is used, these module starts failing with build errors.

This can be verified with(without a code change): west build -t menuconfig and changing the transport to udp, under modules/libmicroros.

A few notes:

The conf in the uart example(src/main.c) does have posix enabled: CONFIG_POSIX_API=y
The serial-usb transport has the right header, line 11:
The udp transport do not have the headers updated, line 7 for unistd.h

Do we need to add posix as conditional? I'm wondering if the udp part was not updated.

pablogs9 commented 1 year ago

Understood, LGTM.

pablogs9 commented 1 year ago

@mergify backport foxy main galactic

mergify[bot] commented 1 year ago

backport foxy main galactic

✅ Backports have been created

* [#113 Adjust zephyr headers for udp (backport #108)](https://github.com/micro-ROS/micro_ros_zephyr_module/pull/113) has been created for branch `foxy` * [#114 Adjust zephyr headers for udp (backport #108)](https://github.com/micro-ROS/micro_ros_zephyr_module/pull/114) has been created for branch `main` * [#115 Adjust zephyr headers for udp (backport #108)](https://github.com/micro-ROS/micro_ros_zephyr_module/pull/115) has been created for branch `galactic`