micro-ROS / micro_ros_zephyr_module

micro-ROS Zephyr module and sample code
Apache License 2.0
54 stars 26 forks source link

Fix header location for zephyr 3.2 for udp. #117

Open gseqBE opened 1 year ago

gseqBE commented 1 year ago

Not sure if the module is ready for Zephyr 3.2 yet, but here is a fix for compilation for udp. Serial transport not affected.

  1. Header Path change(commit-1) image

Changelog of zephyr 3.2 specifies this: image

https://docs.zephyrproject.org/3.2.0/releases/release-notes-3.2.html

  1. Example header update(commit-2)

image

Documentation: image https://docs.zephyrproject.org/3.2.0/releases/release-notes-3.2.html

Edit 1: Added to prj.conf for testing udp(compile only):

CONFIG_MICROROS_TRANSPORT_UDP=y
CONFIG_MICROROS_AGENT_IP="192.168.1.234"
CONFIG_MICROROS_AGENT_PORT="8888"

# Microros Configuration
CONFIG_MICROROS_NODES="1"
CONFIG_MICROROS_PUBLISHERS="25"
CONFIG_MICROROS_SUBSCRIBERS="15"
CONFIG_MICROROS_CLIENTS="2"
CONFIG_MICROROS_SERVERS="2"
CONFIG_MICROROS_RMW_HISTORIC="4"
CONFIG_MICROROS_XRCE_DDS_MTU="512"
CONFIG_MICROROS_XRCE_DDS_HISTORIC="4"
CONFIG_NETWORKING=y
CONFIG_NET_UDP=y
CONFIG_NET_TCP=y
CONFIG_NET_IPV6=y
CONFIG_NET_IPV4=y
CONFIG_NET_SOCKETS=y
CONFIG_NET_SOCKETS_POSIX_NAMES=y
CONFIG_POSIX_MAX_FDS=6
CONFIG_NET_CONNECTION_MANAGER=y
CONFIG_NET_CONFIG_INIT_TIMEOUT=5
pablogs9 commented 1 year ago

@mergify backport main foxy galactic

mergify[bot] commented 1 year ago

backport main foxy galactic

🟠 Waiting for conditions to match

- [ ] `merged` [📌 backport requirement]
pablogs9 commented 1 year ago

This will be merged when Zephyr 3.2 is supported

cmorganBE commented 1 year ago

@pablogs9 are there plans to support zephyr 3.2 in the near future? Was hoping we could get this PR merged in.

pablogs9 commented 1 year ago

@Acuadros95 do we support 3.1 right? Is possible to update to 3.2 as @cmorganBE mentions?

cmorganBE commented 1 year ago

I was actually trying to test against 3.3 (the latest stable release) and was running into boatloads of warnings as the old headers are nearing removal. Was planning at least to fire up a ethernet based test to test round trip time etc. I had to make some other changes to get things to compile but I'm not sure if this PR will fix those yet, plan to re-test as soon as its merged.

pablogs9 commented 1 year ago

PTAL @Acuadros95

clementlgl commented 2 months ago

@pablogs9 The includes in the UDP transport file are not correct for Zephyr versions higher than 3.1. Is it possible to merge the changes proposed by @gseqBE ? Thank you